Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mv egg logger local config to development #7

Closed
wants to merge 1 commit into from
Closed

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Mar 31, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

eggjs/egg#677

@mention-bot
Copy link

@atian25, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jtyjty99999, @popomore and @fengmk2 to be potential reviewers.

@atian25 atian25 requested review from popomore and dead-horse March 31, 2017 03:55
@codecov
Copy link

codecov bot commented Mar 31, 2017

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #7   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          26     25    -1     
=====================================
- Hits           26     25    -1
Impacted Files Coverage Δ
config/config.default.js 100% <100%> (ø) ⬆️
agent.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adbb35c...d72abba. Read the comment docs.

@atian25 atian25 closed this Mar 31, 2017
@atian25 atian25 deleted the logger branch March 31, 2017 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants